Repository navigation
server: encrypt a volume created on a storage pool with an encrypted disk offering - #14667
Draft
weizhouapache wants to merge 1 commit into
Draft
weizhouapache wants to merge 1 commit into
weizhouapache wants to merge 1 commit into
Conversation
…disk offering A volume created with a storageid is created on the pool right away, without the passphrase or the KMS key which an encrypted disk offering needs, so it was created without encryption. Set up its encryption before it is created.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14667 +/- ##
============================================
- Coverage 18.32% 18.31% -0.01%
+ Complexity 16644 16642 -2
============================================
Files 5939 5939
Lines 537787 537794 +7
Branches 65932 65932
============================================
- Hits 98544 98511 -33
- Misses 428033 428079 +46
+ Partials 11210 11204 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A volume created with a storageid is created on the pool right away, without the passphrase or the KMS key which an encrypted disk offering needs, so it was created without encryption. Set up its encryption before it is created.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Environment: Trillian test env
pr147-n88(Ubuntu 26.04, KVM, two management servers, two KVM hosts, Ceph RBD primary poolsceph-pri1andceph-pri2, plus an NFS primary pool). The management servers ran a 4.23 build with the same change, not this 4.22 branch. The KVM agents were not changed.Steps: create an encrypted disk offering (
encrypt=true), then create a volume from it with an explicitstorageidon each pool. The volumes were not attached to a VM.passphrase_idin DBencrypt_formatin DBqemu-img inforeportsencrypted: yesNot covered by these tests:
How did you try to break this feature and the system with this change?
Not yet tested beyond the cases above.